[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-3.1 v10 05/31] block: Respect backing bs in
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename |
Date: |
Wed, 29 Aug 2018 11:44:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-28 15:26, Alberto Garcia wrote:
> On Thu 09 Aug 2018 11:35:02 PM CEST, Max Reitz wrote:
>> + backing_overridden = bdrv_backing_overridden(bs);
>> +
>> + if (bs->open_flags & BDRV_O_NO_IO) {
>> + /* Without I/O, the backing file does not change anything.
>> + * Therefore, in such a case (primarily qemu-img), we can
>> + * pretend the backing file has not been overridden even if
>> + * it technically has been. */
>> + backing_overridden = false;
>> + }
>
> What is this for?
qemu-img info opens files with BDRV_O_NO_BACKING. Without this check,
you'd get a json:{} filename with "backing": null.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull, (continued)
- [Qemu-block] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 03/31] block: Skip implicit nodes for filename info, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 06/31] iotests.py: Add filter_imgfmt(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 07/31] iotests.py: Add node_info(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 09/31] block: Make path_combine() return the path, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 08/31] iotests: Add test for backing file overrides, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 11/31] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 12/31] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 13/31] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 14/31] block: Add bdrv_dirname(), Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 15/31] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 16/31] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/08/09
- [Qemu-block] [PATCH for-3.1 v10 17/31] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/08/09