[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 05/10] block: Allow child references on reope
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 05/10] block: Allow child references on reopen |
Date: |
Wed, 5 Sep 2018 14:40:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-09-03 16:34, Alberto Garcia wrote:
> In the previous patches we removed all child references from
> bs->{options,explicit_options} because keeping them is useless and
> wrong.
>
> Because of this, any attempt to reopen a BlockDriverState using a
> child reference as one of its options would result in a failure,
> because bdrv_reopen_prepare() would detect that there's a new option
> (the child reference) that wasn't present in bs->options.
>
> But passing child references on reopen can be useful. It's a way to
> specify a BDS's child without having to pass recursively all of the
> child's options, and if the reference points to a different BDS then
> this can allow us to replace the child.
>
> However, replacing the child is something that needs to be implemented
> case by case and only when it makes sense. For now, this patch allows
> passing a child reference as long as it points to the current child of
> the BlockDriverState.
>
> It's also important to remember that, as a consequence of the
> previous patches, this child reference will be removed from
> bs->{options,explicit_options} after the reopening has been completed.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen, (continued)
- [Qemu-block] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/09/03
- [Qemu-block] [PATCH v2 01/10] qemu-io: Fix writethrough check in reopen, Alberto Garcia, 2018/09/03
- [Qemu-block] [PATCH v2 04/10] block: Don't look for child references in append_open_options(), Alberto Garcia, 2018/09/03
- [Qemu-block] [PATCH v2 02/10] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/09/03
- [Qemu-block] [PATCH v2 08/10] block: Allow changing 'discard' on reopen, Alberto Garcia, 2018/09/03
- [Qemu-block] [PATCH v2 05/10] block: Allow child references on reopen, Alberto Garcia, 2018/09/03
- Re: [Qemu-block] [PATCH v2 05/10] block: Allow child references on reopen,
Max Reitz <=
- [Qemu-block] [PATCH v2 10/10] block: Allow changing 'force-share' on reopen, Alberto Garcia, 2018/09/03
- [Qemu-block] [PATCH v2 03/10] block: Remove child references from bs->{options, explicit_options}, Alberto Garcia, 2018/09/03