[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 10/16] tests/test-blockjob-txn: move .exit to
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH v5 10/16] tests/test-blockjob-txn: move .exit to .clean |
Date: |
Thu, 6 Sep 2018 12:58:56 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Sep 06, 2018 at 09:02:19AM -0400, John Snow wrote:
> The exit callback in this test actually only performs cleanup.
>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> tests/test-blockjob-txn.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
> index ef29f35e44..86606f92b3 100644
> --- a/tests/test-blockjob-txn.c
> +++ b/tests/test-blockjob-txn.c
> @@ -24,7 +24,7 @@ typedef struct {
> int *result;
> } TestBlockJob;
>
> -static void test_block_job_exit(Job *job)
> +static void test_block_job_clean(Job *job)
> {
> BlockJob *bjob = container_of(job, BlockJob, job);
> BlockDriverState *bs = blk_bs(bjob->blk);
> @@ -73,7 +73,7 @@ static const BlockJobDriver test_block_job_driver = {
> .user_resume = block_job_user_resume,
> .drain = block_job_drain,
> .run = test_block_job_run,
> - .exit = test_block_job_exit,
> + .clean = test_block_job_clean,
> },
> };
>
> --
> 2.14.4
>
- [Qemu-block] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor, (continued)
- [Qemu-block] [PATCH v5 03/16] block/stream: add block job creation flags, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 05/16] block/mirror: don't install backing chain on abort, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 02/16] block/mirror: add block job creation flags, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 10/16] tests/test-blockjob-txn: move .exit to .clean, John Snow, 2018/09/06
- Re: [Qemu-block] [PATCH v5 10/16] tests/test-blockjob-txn: move .exit to .clean,
Jeff Cody <=
- [Qemu-block] [PATCH v5 14/16] qapi/block-stream: expose new job properties, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 11/16] jobs: remove .exit callback, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 09/16] tests/test-blockjob: remove exit callback, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 07/16] block/stream: refactor stream to use job callbacks, John Snow, 2018/09/06