[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 12/14] mips_malta: Clean up definition of flash m
From: |
Markus Armbruster |
Subject: |
[Qemu-block] [PATCH v3 12/14] mips_malta: Clean up definition of flash memory size somewhat |
Date: |
Thu, 7 Mar 2019 14:03:21 +0100 |
pflash_cfi01_register() takes a size in bytes, a block size in bytes
and a number of blocks. mips_malta_init() passes BIOS_SIZE, 65536,
FLASH_SIZE >> 16. Actually consistent only because BIOS_SIZE (defined
in include/hw/mips/bios.h as (4 * MiB)) matches FLASH_SIZE (defined
locally as 0x400000). Confusing all the same.
Pass FLASH_SIZE instead of BIOS_SIZE.
Cc: Aurelien Jarno <address@hidden>
Cc: Aleksandar Rikalo <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
hw/mips/mips_malta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index e6a67bab1d..f63b1c4776 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1275,7 +1275,7 @@ void mips_malta_init(MachineState *machine)
#endif
}
fl = pflash_cfi01_register(FLASH_ADDRESS, NULL, "mips_malta.bios",
- BIOS_SIZE,
+ FLASH_SIZE,
pflash_blk,
65536, FLASH_SIZE >> 16,
4, 0x0000, 0x0000, 0x0000, 0x0000, be);
--
2.17.2
- [Qemu-block] [PATCH v3 00/14] pflash: Fixes and cleanups, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 10/14] hw/mips/malta: Remove fl_sectors variable, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 04/14] pflash: Rename *CFI_PFLASH* to *PFLASH_CFI*, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 12/14] mips_malta: Clean up definition of flash memory size somewhat,
Markus Armbruster <=
- [Qemu-block] [PATCH v3 13/14] pflash: Clean up after commit 368a354f02b, part 1, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 03/14] pflash_cfi01: Log use of flawed "write to buffer", Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 09/14] hw/mips/malta: Fix the DEBUG_BOARD_INIT code, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 01/14] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 14/14] pflash: Clean up after commit 368a354f02b, part 2, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 11/14] hw/mips/malta: Restrict 'bios_size' variable scope, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v3 06/14] sam460ex: Don't size flash memory to match backing image, Markus Armbruster, 2019/03/07