[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH 01/10] monitor: Remove unused password promp
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-block] [RFC PATCH 01/10] monitor: Remove unused password prompting fields |
Date: |
Fri, 7 Jun 2019 16:39:20 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Kevin Wolf (address@hidden) wrote:
> Commit 788cf9f8c removed the code for password prompting from the
> monitor. Since then, the Monitor fields password_completion_cb and
> password_opaque have been unused. Remove them.
>
> Signed-off-by: Kevin Wolf <address@hidden>
A shame, I love the idea of password completion. 123<tab>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> monitor.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 6428eb3b7e..70ce9e8a77 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -220,8 +220,6 @@ struct Monitor {
>
> MonitorQMP qmp;
> gchar *mon_cpu_path;
> - BlockCompletionFunc *password_completion_cb;
> - void *password_opaque;
> mon_cmd_t *cmd_table;
> QTAILQ_ENTRY(Monitor) entry;
>
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-block] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 01/10] monitor: Remove unused password prompting fields, Kevin Wolf, 2019/06/07
- Re: [Qemu-block] [RFC PATCH 01/10] monitor: Remove unused password prompting fields,
Dr. David Alan Gilbert <=
- [Qemu-block] [RFC PATCH 05/10] monitor: Move cmd_table to MonitorHMP, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 02/10] monitor: Split monitor_init in HMP and QMP function, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 04/10] monitor: Create MonitorHMP with readline state, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 06/10] Move monitor.c to monitor/misc.c, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 07/10] monitor: Create monitor_int.h with common definitions, Kevin Wolf, 2019/06/07