[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH 0/8] Add Qemu to SeaBIOS LCHS i
From: |
no-reply |
Subject: |
Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH 0/8] Add Qemu to SeaBIOS LCHS interface |
Date: |
Wed, 12 Jun 2019 03:12:13 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [SeaBIOS] [QEMU] [PATCH 0/8] Add Qemu to SeaBIOS LCHS interface
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a9a0cfc956 hd-geo-test: Add tests for lchs override
d1b86f9f47 bootdevice: FW_CFG interface for LCHS values
48dd083d65 bootdevice: Refactor get_boot_devices_list
f37e8f7c3c bootdevice: Gather LCHS from all relevant devices
8a7193c16b scsi: Propagate unrealize() callback to scsi-hd
c0a3a43fe2 bootdevice: Add interface to gather LCHS
9ebc9c1fd9 block: Support providing LCHS from user
6593400075 block: Refactor macros - fix tabbing
=== OUTPUT BEGIN ===
1/8 Checking commit 659340007537 (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
+ DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
+ DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
total: 1 errors, 0 warnings, 37 lines checked
Patch 1/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 9ebc9c1fd9a2 (block: Support providing LCHS from user)
3/8 Checking commit c0a3a43fe22e (bootdevice: Add interface to gather LCHS)
4/8 Checking commit 8a7193c16bb9 (scsi: Propagate unrealize() callback to
scsi-hd)
5/8 Checking commit f37e8f7c3cc6 (bootdevice: Gather LCHS from all relevant
devices)
6/8 Checking commit 48dd083d65ed (bootdevice: Refactor get_boot_devices_list)
7/8 Checking commit d1b86f9f478c (bootdevice: FW_CFG interface for LCHS values)
8/8 Checking commit a9a0cfc956a7 (hd-geo-test: Add tests for lchs override)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-block] [QEMU] [PATCH 1/8] block: Refactor macros - fix tabbing, (continued)
- [Qemu-block] [QEMU] [PATCH 1/8] block: Refactor macros - fix tabbing, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 2/8] block: Support providing LCHS from user, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 3/8] bootdevice: Add interface to gather LCHS, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 4/8] scsi: Propagate unrealize() callback to scsi-hd, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 5/8] bootdevice: Gather LCHS from all relevant devices, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 6/8] bootdevice: Refactor get_boot_devices_list, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 7/8] bootdevice: FW_CFG interface for LCHS values, Sam Eiderman, 2019/06/12
- [Qemu-block] [QEMU] [PATCH 8/8] hd-geo-test: Add tests for lchs override, Sam Eiderman, 2019/06/12
- Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH 0/8] Add Qemu to SeaBIOS LCHS interface,
no-reply <=
- Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH 0/8] Add Qemu to SeaBIOS LCHS interface, no-reply, 2019/06/12