[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 06/11] Move monitor.c to monitor
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 06/11] Move monitor.c to monitor/misc.c |
Date: |
Wed, 12 Jun 2019 13:57:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Create a new monitor/ subdirectory and move monitor.c there. As the plan
> is to move the monitor core into separate files, use the chance to
> rename it to misc.c.
I figure we'll want to move most of (all of?) monitor/misc.c out. Not a
job this series must finish, of course.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> docs/devel/writing-qmp-commands.txt | 2 +-
> monitor.c => monitor/misc.c | 2 +-
> MAINTAINERS | 4 ++--
> Makefile.objs | 1 +
> Makefile.target | 3 ++-
> monitor/Makefile.objs | 1 +
> monitor/trace-events | 11 +++++++++++
> trace-events | 10 ----------
> 8 files changed, 19 insertions(+), 15 deletions(-)
> rename monitor.c => monitor/misc.c (99%)
> create mode 100644 monitor/Makefile.objs
> create mode 100644 monitor/trace-events
>
> diff --git a/docs/devel/writing-qmp-commands.txt
> b/docs/devel/writing-qmp-commands.txt
> index 9dfc62bf5a..cc6ecd6d5d 100644
> --- a/docs/devel/writing-qmp-commands.txt
> +++ b/docs/devel/writing-qmp-commands.txt
> @@ -470,7 +470,7 @@ it's good practice to always check for errors.
>
> Another important detail is that HMP's "info" commands don't go into the
> hmp-commands.hx. Instead, they go into the info_cmds[] table, which is
> defined
> -in the monitor.c file. The entry for the "info alarmclock" follows:
> +in the monitor/misc.c file. The entry for the "info alarmclock" follows:
Not this patch's fault, but this is wrong since commit da76ee76f78 (Sep
2015).
Funny, the one place that provides advice on writing HMP commands is
called writing-qmp-commands.txt %-}
>
> {
> .name = "alarmclock",
[...]
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-block] [PATCH v2.1 02.5/11] monitor: Restrict use of Monitor member qmp to actual QMP monitors, (continued)
[Qemu-block] [PATCH v2 05/11] monitor: Move cmd_table to MonitorHMP, Kevin Wolf, 2019/06/11
[Qemu-block] [PATCH v2 06/11] Move monitor.c to monitor/misc.c, Kevin Wolf, 2019/06/11
[Qemu-block] [PATCH v2 08/11] monitor: Create monitor_int.h with common definitions, Kevin Wolf, 2019/06/11
[Qemu-block] [PATCH v2 07/11] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c, Kevin Wolf, 2019/06/11
[Qemu-block] [PATCH v2 09/11] monitor: Split out monitor/qmp.c, Kevin Wolf, 2019/06/11