[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 02/42] copy-on-read: Support compressed write
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH v5 02/42] copy-on-read: Support compressed writes |
Date: |
Thu, 13 Jun 2019 10:49:56 +0000 |
13.06.2019 1:09, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/copy-on-read.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/block/copy-on-read.c b/block/copy-on-read.c
> index 53972b1da3..88e1c1f538 100644
> --- a/block/copy-on-read.c
> +++ b/block/copy-on-read.c
> @@ -114,6 +114,16 @@ static int coroutine_fn cor_co_pdiscard(BlockDriverState
> *bs,
> }
>
>
> +static int coroutine_fn cor_co_pwritev_compressed(BlockDriverState *bs,
> + uint64_t offset,
> + uint64_t bytes,
> + QEMUIOVector *qiov)
> +{
> + return bdrv_co_pwritev(bs->file, offset, bytes, qiov,
> + BDRV_REQ_WRITE_COMPRESSED);
> +}
Hmm, possibly it's better to handle support of compression by checking supported
flags
> +
> +
> static void cor_eject(BlockDriverState *bs, bool eject_flag)
> {
> bdrv_eject(bs->file->bs, eject_flag);
> @@ -146,6 +156,7 @@ static BlockDriver bdrv_copy_on_read = {
> .bdrv_co_pwritev = cor_co_pwritev,
> .bdrv_co_pwrite_zeroes = cor_co_pwrite_zeroes,
> .bdrv_co_pdiscard = cor_co_pdiscard,
> + .bdrv_co_pwritev_compressed = cor_co_pwritev_compressed,
>
> .bdrv_eject = cor_eject,
> .bdrv_lock_medium = cor_lock_medium,
>
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v5 00/42] block: Deal with filters, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 01/42] block: Mark commit and mirror as filter drivers, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 02/42] copy-on-read: Support compressed writes, Max Reitz, 2019/06/12
- Re: [Qemu-block] [PATCH v5 02/42] copy-on-read: Support compressed writes,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH v5 03/42] throttle: Support compressed writes, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 04/42] block: Add child access functions, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 05/42] block: Add chain helper functions, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 06/42] qcow2: Implement .bdrv_storage_child(), Max Reitz, 2019/06/12