[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 12/42] block: Use bdrv_filtered_rw* where obv
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH v5 12/42] block: Use bdrv_filtered_rw* where obvious |
Date: |
Thu, 13 Jun 2019 13:37:12 +0000 |
13.06.2019 1:09, Max Reitz wrote:
> Places that use patterns like
>
> if (bs->drv->is_filter && bs->file) {
> ... something about bs->file->bs ...
> }
>
> should be
>
> BlockDriverState *filtered = bdrv_filtered_rw_bs(bs);
> if (filtered) {
> ... something about @filtered ...
> }
>
> instead.
Hmm, in other words, support filters with backing child in all places, where
only file-based
filters are supported, as we don't want make any semantic difference between
these two
types of filters.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v5 10/42] block: Use CAF in bdrv_is_encrypted(), (continued)
- [Qemu-block] [PATCH v5 10/42] block: Use CAF in bdrv_is_encrypted(), Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 11/42] block: Add bdrv_supports_compressed_writes(), Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 09/42] block: Include filters when freezing backing chain, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 12/42] block: Use bdrv_filtered_rw* where obvious, Max Reitz, 2019/06/12
- Re: [Qemu-block] [PATCH v5 12/42] block: Use bdrv_filtered_rw* where obvious,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH v5 13/42] block: Use CAFs in block status functions, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 14/42] block: Use CAFs when working with backing chains, Max Reitz, 2019/06/12
[Qemu-block] [PATCH v5 15/42] block: Re-evaluate backing file handling in reopen, Max Reitz, 2019/06/12