[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v9] ssh: switch from libssh2 to libssh
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v9] ssh: switch from libssh2 to libssh |
Date: |
Thu, 13 Jun 2019 15:06:02 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/13/19 2:31 PM, Max Reitz wrote:
>> @@ -657,71 +644,147 @@ static int connect_to_ssh(BDRVSSHState *s,
>> BlockdevOptionsSsh *opts,
>
> [...]
>
>> + /*
>> + * Try to disable the Nagle algorithm on TCP sockets to reduce latency,
>> + * but do not fail if it cannot be disabled.
>> + */
>> + r = socket_set_nodelay(new_sock);
>> + if (r < 0) {
>> + warn_report("setting NODELAY for the ssh server %s failed: %m",
>
> TIL about %m.
printf("%m") is not portable to non-glibc. Spell it out as
"%s",strerror(errno). (It _is_ portable for syslog(), but warn_report()
is not wired to syslog() semantics).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature