[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/15] Move monitor.c to monitor
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/15] Move monitor.c to monitor/misc.c |
Date: |
Fri, 14 Jun 2019 08:25:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Kevin Wolf <address@hidden> writes:
>
>> Create a new monitor/ subdirectory and move monitor.c there. As the plan
>> is to move the monitor core into separate files, use the chance to
>> rename it to misc.c.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> ---
>> docs/devel/writing-qmp-commands.txt | 2 +-
>> monitor.c => monitor/misc.c | 2 +-
>> MAINTAINERS | 4 ++--
>> Makefile.objs | 1 +
>> Makefile.target | 3 ++-
>> monitor/Makefile.objs | 1 +
>> monitor/trace-events | 11 +++++++++++
>> trace-events | 10 ----------
>> 8 files changed, 19 insertions(+), 15 deletions(-)
>> rename monitor.c => monitor/misc.c (99%)
>> create mode 100644 monitor/Makefile.objs
>> create mode 100644 monitor/trace-events
>
> I still think we should move hmp.h to include/monitor/.
Comment applies to the next patch, sorry.
> hmp-commands-info.hx and hmp-commands.hx, too. Not worth a respin by
> itself.
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 03/15] monitor: Make MonitorQMP a child class of Monitor, (continued)
- [Qemu-block] [PATCH v3 02/15] monitor: Split monitor_init in HMP and QMP function, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 05/15] monitor: Remove Monitor.cmd_table indirection, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 06/15] monitor: Rename HMP command type and tables, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 07/15] Move monitor.c to monitor/misc.c, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 09/15] monitor: Create monitor-internal.h with common definitions, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 08/15] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 04/15] monitor: Create MonitorHMP with readline state, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 10/15] monitor: Split out monitor/qmp.c, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 14/15] monitor: Replace monitor_init() with monitor_init_{hmp, qmp}(), Kevin Wolf, 2019/06/13