[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/6] configure: Only generate GLUSTERFS variable
From: |
Niels de Vos |
Subject: |
Re: [Qemu-block] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable |
Date: |
Fri, 14 Jun 2019 09:43:10 +0200 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Fri, Jun 14, 2019 at 09:24:27AM +0200, Philippe Mathieu-Daudé wrote:
> It is pointless and confusing to have GLUSTERFS variables
> in config-host.mak when glusterfs is not usable.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Looks good to me, thanks.
Reviewed-by: Niels de Vos <address@hidden>
> ---
> configure | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/configure b/configure
> index b091b82cb3..13fd4a1166 100755
> --- a/configure
> +++ b/configure
> @@ -7118,30 +7118,30 @@ if test "$glusterfs" = "yes" ; then
> echo "CONFIG_GLUSTERFS=m" >> $config_host_mak
> echo "GLUSTERFS_CFLAGS=$glusterfs_cflags" >> $config_host_mak
> echo "GLUSTERFS_LIBS=$glusterfs_libs" >> $config_host_mak
> -fi
>
> -if test "$glusterfs_xlator_opt" = "yes" ; then
> - echo "CONFIG_GLUSTERFS_XLATOR_OPT=y" >> $config_host_mak
> -fi
> + if test "$glusterfs_xlator_opt" = "yes" ; then
> + echo "CONFIG_GLUSTERFS_XLATOR_OPT=y" >> $config_host_mak
> + fi
>
> -if test "$glusterfs_discard" = "yes" ; then
> - echo "CONFIG_GLUSTERFS_DISCARD=y" >> $config_host_mak
> -fi
> + if test "$glusterfs_discard" = "yes" ; then
> + echo "CONFIG_GLUSTERFS_DISCARD=y" >> $config_host_mak
> + fi
>
> -if test "$glusterfs_fallocate" = "yes" ; then
> - echo "CONFIG_GLUSTERFS_FALLOCATE=y" >> $config_host_mak
> -fi
> + if test "$glusterfs_fallocate" = "yes" ; then
> + echo "CONFIG_GLUSTERFS_FALLOCATE=y" >> $config_host_mak
> + fi
>
> -if test "$glusterfs_zerofill" = "yes" ; then
> - echo "CONFIG_GLUSTERFS_ZEROFILL=y" >> $config_host_mak
> -fi
> + if test "$glusterfs_zerofill" = "yes" ; then
> + echo "CONFIG_GLUSTERFS_ZEROFILL=y" >> $config_host_mak
> + fi
>
> -if test "$glusterfs_ftruncate_has_stat" = "yes" ; then
> - echo "CONFIG_GLUSTERFS_FTRUNCATE_HAS_STAT=y" >> $config_host_mak
> -fi
> + if test "$glusterfs_ftruncate_has_stat" = "yes" ; then
> + echo "CONFIG_GLUSTERFS_FTRUNCATE_HAS_STAT=y" >> $config_host_mak
> + fi
>
> -if test "$glusterfs_iocb_has_stat" = "yes" ; then
> - echo "CONFIG_GLUSTERFS_IOCB_HAS_STAT=y" >> $config_host_mak
> + if test "$glusterfs_iocb_has_stat" = "yes" ; then
> + echo "CONFIG_GLUSTERFS_IOCB_HAS_STAT=y" >> $config_host_mak
> + fi
> fi
>
> if test "$libssh2" = "yes" ; then
> --
> 2.20.1
>
- [Qemu-block] [PATCH 0/6] configure: Try to fix --static linking, Philippe Mathieu-Daudé, 2019/06/14
- [Qemu-block] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable, Philippe Mathieu-Daudé, 2019/06/14
- Re: [Qemu-block] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable,
Niels de Vos <=
- [Qemu-block] [PATCH 2/6] configure: Link test before auto-enabling glusterfs libraries, Philippe Mathieu-Daudé, 2019/06/14
- [Qemu-block] [PATCH 3/6] configure: Link test before auto-enabling the libusb library, Philippe Mathieu-Daudé, 2019/06/14
- [Qemu-block] [PATCH 4/6] configure: Link test before auto-enabling the libusbredir library, Philippe Mathieu-Daudé, 2019/06/14
- [Qemu-block] [PATCH 5/6] configure: Link test before auto-enabling the pulseaudio library, Philippe Mathieu-Daudé, 2019/06/14
- [Qemu-block] [PATCH 6/6] .travis.yml: Test static linking, Philippe Mathieu-Daudé, 2019/06/14
- Re: [Qemu-block] [PATCH 0/6] configure: Try to fix --static linking, Philippe Mathieu-Daudé, 2019/06/14
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] configure: Try to fix --static linking, Peter Maydell, 2019/06/14