[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/7] iotests: Valgrind fails to work with non
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory |
Date: |
Mon, 17 Jun 2019 13:22:04 +0200 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 13.06.2019 um 11:52 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 11.06.2019 21:02, Andrey Shinkevich wrote:
> > The Valgrind uses the exported variable TMPDIR and fails if the
> > directory does not exist. Let us exclude such a test case from
> > being run under the Valgrind.
> >
> > Signed-off-by: Andrey Shinkevich <address@hidden>
>
> Hmm, isn't it preferable to skip unsupported by
> valgrind iotests, instead silently disable valgrind in them?
You mean like this at the start of the script?
[ "$VALGRIND_QEMU" == "y" ] && _notrun "valgrind needs a working TMPDIR"
I agree that silently doing something different that the user requested
is bad and visibly skipping the test is often better. On the other hand,
051 is relatively long and it's only one subtest that doesn't work with
valgrind.
Hm... How about we do run the test, but put a note in the casenotrun
file so it's visible that we didn't use valgrind for everything?
Kevin
[Qemu-block] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory, Andrey Shinkevich, 2019/06/11
[Qemu-block] [PATCH v2 6/7] iotests: amend QEMU NBD process synchronization, Andrey Shinkevich, 2019/06/11
[Qemu-block] [PATCH v2 4/7] iotests: extended timeout under Valgrind, Andrey Shinkevich, 2019/06/11
[Qemu-block] [PATCH v2 1/7] iotests: allow Valgrind checking all QEMU processes, Andrey Shinkevich, 2019/06/11