[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: enable non-root nodes fo
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source |
Date: |
Tue, 18 Jun 2019 10:57:50 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/18/19 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> We forget to enable it for transaction .prepare, while it is already
> enabled in do_drive_backup since commit a2d665c1bc362
> "blockdev: loosen restrictions on drive-backup source node"
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>
> Hmm, I've to add John by hand, get_maintainer.pl don't report him.
> Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS?
> It definitely related to block jobs.
>
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index b5c0fd3c49..4ae81d687a 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1775,7 +1775,7 @@ static void drive_backup_prepare(BlkActionState
> *common, Error **errp)
> assert(common->action->type == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
> backup = common->action->u.drive_backup.data;
>
> - bs = qmp_get_root_bs(backup->device, errp);
> + bs = bdrv_lookup_bs(backup->device, backup->device, errp);
> if (!bs) {
> return;
> }
>
I'm half asleep, sorry, this isn't related to the patch that
necessitated 256. This is fine as-is.
Reviewed-by: John Snow <address@hidden>