[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 31/42] block: Drop backing_bs()
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH v5 31/42] block: Drop backing_bs() |
Date: |
Wed, 19 Jun 2019 09:18:43 +0000 |
13.06.2019 1:09, Max Reitz wrote:
> We want to make it explicit where bs->backing is used, and we have done
> so. The old role of backing_bs() is now effectively taken by
> bdrv_filtered_cow_bs().
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> include/block/block_int.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index 875a33f255..c0a05beec3 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -925,11 +925,6 @@ typedef enum BlockMirrorBackingMode {
> MIRROR_LEAVE_BACKING_CHAIN,
> } BlockMirrorBackingMode;
>
> -static inline BlockDriverState *backing_bs(BlockDriverState *bs)
> -{
> - return bs->backing ? bs->backing->bs : NULL;
> -}
> -
>
> /* Essential block drivers which must always be statically linked into
> qemu, and
> * which therefore can be accessed without using bdrv_find_format() */
>
--
Best regards,
Vladimir
- Re: [Qemu-block] [PATCH v5 22/42] block: Use CAFs in bdrv_get_allocated_file_size(), (continued)
- [Qemu-block] [PATCH v5 26/42] backup: Deal with filters, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 27/42] commit: Deal with filters, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 29/42] nbd: Use CAF when looking for dirty bitmap, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 28/42] stream: Deal with filters, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 31/42] block: Drop backing_bs(), Max Reitz, 2019/06/12
- Re: [Qemu-block] [PATCH v5 31/42] block: Drop backing_bs(),
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH v5 32/42] block: Make bdrv_get_cumulative_perm() public, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 33/42] blockdev: Fix active commit choice, Max Reitz, 2019/06/12
- [Qemu-block] [PATCH v5 30/42] qemu-img: Use child access functions, Max Reitz, 2019/06/12