[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH V2] block/replication.c: Fix crash issue after failo
From: |
Zhang Chen |
Subject: |
[Qemu-block] [PATCH V2] block/replication.c: Fix crash issue after failover |
Date: |
Fri, 21 Jun 2019 13:52:02 +0800 |
From: Zhang Chen <address@hidden>
If we try to close replication after failover, it will crash here.
So we need check the block job on active disk before cancel the job.
Signed-off-by: Zhang Chen <address@hidden>
---
block/replication.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/replication.c b/block/replication.c
index 3d4dedddfc..845f796dd4 100644
--- a/block/replication.c
+++ b/block/replication.c
@@ -146,7 +146,9 @@ static void replication_close(BlockDriverState *bs)
replication_stop(s->rs, false, NULL);
}
if (s->stage == BLOCK_REPLICATION_FAILOVER) {
- job_cancel_sync(&s->active_disk->bs->job->job);
+ if (s->active_disk->bs->job) {
+ job_cancel_sync(&s->active_disk->bs->job->job);
+ }
}
if (s->mode == REPLICATION_MODE_SECONDARY) {
--
2.17.GIT
- [Qemu-block] [PATCH V2] block/replication.c: Fix crash issue after failover,
Zhang Chen <=