[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*
From: |
Sam Eiderman |
Subject: |
Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions |
Date: |
Sat, 22 Jun 2019 20:33:22 +0300 |
> On 22 Jun 2019, at 18:27, Kevin O'Connor <address@hidden> wrote:
>
> On Sat, Jun 22, 2019 at 11:51:48AM +0300, Sam Eiderman wrote:
>> But maybe someone wants bootorder but doesn’t want to override legacy disk
>> translations…
>>
>> I’m thinking of maybe adding
>>
>> if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GEOMETRY)
>> return NULL;
>
> That's fine - though it's (!CONFIG_BOOTORDER && !CONFIG_BIOS_GEOMETRY).
Yes of course, my bad
>
> FYI, I think BIOS_GEOMETRY is a little confusing - maybe
> CUSTOM_DISK_GEOMETRY.
The thing is that disk geometry is actually (physical geometry, reported by the
disk controller) and here
bios geometry stands for the geometry reported from bios int13.
Also “bios geometry” === “logical geometry” === “lchs”.
So following previous discussion with Gerd, maybe CONFIG_HOST_BIOS_GEOMETRY is
better?
Sam
>
> -Kevin
- [Qemu-block] [SeaBIOS] [PATCH v3 0/4] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/06/19
- [Qemu-block] [SeaBIOS] [PATCH v3 1/4] geometry: Read LCHS from fw_cfg, Sam Eiderman, 2019/06/19
- [Qemu-block] [SeaBIOS] [PATCH v3 2/4] boot: Reorder functions in boot.c, Sam Eiderman, 2019/06/19
- [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/19
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Kevin O'Connor, 2019/06/20
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/21
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Kevin O'Connor, 2019/06/21
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/22
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Kevin O'Connor, 2019/06/22
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions,
Sam Eiderman <=
- Re: [Qemu-block] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/26
[Qemu-block] [SeaBIOS] [PATCH v3 4/4] geometry: Apply LCHS values for boot devices, Sam Eiderman, 2019/06/19