[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH V2 2/3] block/accounting: introduce block size histo
From: |
zhenwei pi |
Subject: |
[Qemu-block] [PATCH V2 2/3] block/accounting: introduce block size histogram |
Date: |
Mon, 24 Jun 2019 14:49:35 +0800 |
Introduce block size histogram statics for block devices.
For read/write/flush operation type, the block size region
[0, +inf) is divided into subregions by several points.
It works like block latency histogram.
Signed-off-by: zhenwei pi <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/accounting.c | 18 ++++++++++++++++++
include/block/accounting.h | 5 ++++-
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/block/accounting.c b/block/accounting.c
index d210a73fe9..3a1e41a971 100644
--- a/block/accounting.c
+++ b/block/accounting.c
@@ -192,6 +192,22 @@ void block_latency_histograms_clear(BlockAcctStats *stats)
}
}
+int block_size_histogram_set(BlockAcctStats *stats, enum BlockAcctType type,
+ uint64List *boundaries)
+{
+ BlockHistogram *hist = &stats->size_histogram[type];
+
+ return block_histogram_set(hist, boundaries);
+}
+
+void block_size_histograms_clear(BlockAcctStats *stats)
+{
+ int i;
+
+ for (i = 0; i < BLOCK_MAX_IOTYPE; i++) {
+ block_histogram_clear(&stats->size_histogram[i]);
+ }
+}
static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie
*cookie,
bool failed)
{
@@ -216,6 +232,8 @@ static void block_account_one_io(BlockAcctStats *stats,
BlockAcctCookie *cookie,
block_histogram_account(&stats->latency_histogram[cookie->type],
latency_ns);
+ block_histogram_account(&stats->size_histogram[cookie->type],
+ cookie->bytes);
if (!failed || stats->account_failed) {
stats->total_time_ns[cookie->type] += latency_ns;
diff --git a/include/block/accounting.h b/include/block/accounting.h
index 270fddb69c..0fbba64408 100644
--- a/include/block/accounting.h
+++ b/include/block/accounting.h
@@ -89,6 +89,7 @@ struct BlockAcctStats {
bool account_invalid;
bool account_failed;
BlockHistogram latency_histogram[BLOCK_MAX_IOTYPE];
+ BlockHistogram size_histogram[BLOCK_MAX_IOTYPE];
};
typedef struct BlockAcctCookie {
@@ -117,5 +118,7 @@ double block_acct_queue_depth(BlockAcctTimedStats *stats,
int block_latency_histogram_set(BlockAcctStats *stats, enum BlockAcctType type,
uint64List *boundaries);
void block_latency_histograms_clear(BlockAcctStats *stats);
-
+int block_size_histogram_set(BlockAcctStats *stats, enum BlockAcctType type,
+ uint64List *boundaries);
+void block_size_histograms_clear(BlockAcctStats *stats);
#endif
--
2.11.0