[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 0/7] Allow Valgrind checking all QEMU processes
From: |
Andrey Shinkevich |
Subject: |
[Qemu-block] [PATCH v3 0/7] Allow Valgrind checking all QEMU processes |
Date: |
Fri, 28 Jun 2019 16:46:07 +0300 |
In the current implementation of the QEMU bash iotests, only qemu-io
processes may be run under the Valgrind, which is a useful tool for
finding memory usage issues. Let's allow the common.rc bash script
runing all the QEMU processes, such as qemu-kvm, qemu-img, qemu-ndb
and qemu-vxhs, under the Valgrind tool.
v3:
01: The new function _casenotrun() was added to the common.rc bash
script to notify the user of test cases dropped for some reason.
Suggested by Kevin.
Particularly, the notification about the nonexistent TMPDIR in
the test 051 was added (noticed by Vladimir).
02: The timeout in some test cases was extended for Valgrind because
it differs when running on the ramdisk.
03: Due to the common.nbd script has been changed with the commit
b28f582c, the patch "iotests: amend QEMU NBD process synchronization"
is actual no more. Note that QEMU_NBD is launched in the bash nested
shell in the _qemu_nbd_wrapper() as it was before in common.rc.
04: The patch "iotests: new file to suppress Valgrind errors" was dropped
due to my superficial understanding of the work of the function
blk_pread_unthrottled(). Special thanks to Kevin who shed the light
on the null block driver involved. Now, the parameter 'read-zeroes=on'
is passed to the null block driver to initialize the buffer in the
function guess_disk_lchs() that the Valgrind was complaining to.
v2:
01: The patch 2/7 of v1 was merged into the patch 1/7, suggested by Daniel.
02: Another patch 7/7 was added to introduce the Valgrind error suppression
file into the QEMU project.
Discussed in the email thread with the message ID:
<address@hidden>
Andrey Shinkevich (7):
iotests: allow Valgrind checking all QEMU processes
iotests: exclude killed processes from running under Valgrind
iotests: Add casenotrun report to bash tests
iotests: Valgrind fails with nonexistent directory
iotests: extended timeout under Valgrind
iotests: extend sleeping time under Valgrind
iotests: Set read-zeroes on in null block driver for Valgrind
tests/qemu-iotests/028 | 6 +-
tests/qemu-iotests/039 | 5 ++
tests/qemu-iotests/039.out | 30 ++-------
tests/qemu-iotests/051 | 14 ++--
tests/qemu-iotests/051.pc.out | 10 +--
tests/qemu-iotests/061 | 2 +
tests/qemu-iotests/061.out | 12 +---
tests/qemu-iotests/137 | 1 +
tests/qemu-iotests/137.out | 6 +-
tests/qemu-iotests/183 | 9 ++-
tests/qemu-iotests/186 | 20 +++---
tests/qemu-iotests/186.out | 152 +++++++++++++++++++++---------------------
tests/qemu-iotests/192 | 6 +-
tests/qemu-iotests/227 | 4 +-
tests/qemu-iotests/227.out | 4 +-
tests/qemu-iotests/240 | 8 +--
tests/qemu-iotests/247 | 6 +-
tests/qemu-iotests/common.rc | 76 ++++++++++++++++-----
18 files changed, 205 insertions(+), 166 deletions(-)
--
1.8.3.1
- [Qemu-block] [PATCH v3 0/7] Allow Valgrind checking all QEMU processes,
Andrey Shinkevich <=
- [Qemu-block] [PATCH v3 2/7] iotests: exclude killed processes from running under Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 4/7] iotests: Valgrind fails with nonexistent directory, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 6/7] iotests: extend sleeping time under Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 7/7] iotests: Set read-zeroes on in null block driver for Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 3/7] iotests: Add casenotrun report to bash tests, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 5/7] iotests: extended timeout under Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 1/7] iotests: allow Valgrind checking all QEMU processes, Andrey Shinkevich, 2019/06/28