Re: [Qemu-block] [PATCH v3 1/4] block: introduce aio task pool

[Max Reitz]

On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote:
> Common interface for aio task loops. To be used for improving
> performance of synchronous io loops in qcow2, block-stream,
> copy-on-read, and may be other places.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  include/block/aio_task.h |  54 +++++++++++++++++
>  block/aio_task.c         | 124 +++++++++++++++++++++++++++++++++++++++
>  block/Makefile.objs      |   2 +
>  3 files changed, 180 insertions(+)
>  create mode 100644 include/block/aio_task.h
>  create mode 100644 block/aio_task.c
> 
> diff --git a/include/block/aio_task.h b/include/block/aio_task.h
> new file mode 100644
> index 0000000000..58b4d99e59
> --- /dev/null
> +++ b/include/block/aio_task.h

[...]

> +AioTaskPool *aio_task_pool_new(int max_busy_tasks);

Because aio_task_pool_wait_one() asserts that it runs in the same
coroutine as aio_task_pool_new(), this should be a coroutine_fn as well.
O:-)

But I don’t want to be responsible for breaking your “1” key (assuming
you have the exclamation mark there):

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature