[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041
From: |
Max Reitz |
Subject: |
[PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041 |
Date: |
Mon, 11 Nov 2019 17:02:12 +0100 |
Signed-off-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/041 | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 2ab59e9c53..d636cb7f1d 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -918,8 +918,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
self.complete_and_wait(drive="job0")
self.assert_has_block_node("repair0", quorum_repair_img)
- # TODO: a better test requiring some QEMU infrastructure will be added
- # to check that this file is really driven by quorum
+ self.vm.assert_block_path('quorum0', '/children.1', 'repair0')
self.vm.shutdown()
self.assertTrue(iotests.compare_images(quorum_img2, quorum_repair_img),
'target image does not match source after mirroring')
@@ -1041,9 +1040,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
self.complete_and_wait('job0')
self.assert_has_block_node("repair0", quorum_repair_img)
- # TODO: a better test requiring some QEMU infrastructure will be added
- # to check that this file is really driven by quorum
- self.vm.shutdown()
+ self.vm.assert_block_path('quorum0', '/children.1', 'repair0')
# Test mirroring with a source that does not have any parents (not even a
# BlockBackend)
--
2.23.0
- Re: [PATCH for-5.0 v2 13/23] mirror: Double-check immediately before replacing, (continued)
- [PATCH for-5.0 v2 14/23] quorum: Stop marking it as a filter, Max Reitz, 2019/11/11
- [PATCH for-5.0 v2 16/23] iotests: Use complete_and_wait() in 155, Max Reitz, 2019/11/11
- [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Max Reitz, 2019/11/11
- Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Vladimir Sementsov-Ogievskiy, 2019/11/29
- Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Max Reitz, 2019/11/29
- Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Vladimir Sementsov-Ogievskiy, 2019/11/29
- Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Max Reitz, 2019/11/29
- Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Vladimir Sementsov-Ogievskiy, 2019/11/29
- Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops, Max Reitz, 2019/11/29
[PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041,
Max Reitz <=
[PATCH for-5.0 v2 17/23] iotests: Use skip_if_unsupported decorator in 041, Max Reitz, 2019/11/11
[PATCH for-5.0 v2 18/23] iotests: Add VM.assert_block_path(), Max Reitz, 2019/11/11
[PATCH for-5.0 v2 20/23] iotests: Use self.image_len in TestRepairQuorum, Max Reitz, 2019/11/11
[PATCH for-5.0 v2 22/23] iotests: Check that @replaces can replace filters, Max Reitz, 2019/11/11
[PATCH for-5.0 v2 21/23] iotests: Add tests for invalid Quorum @replaces, Max Reitz, 2019/11/11
[PATCH for-5.0 v2 23/23] iotests: Mirror must not attempt to create loops, Max Reitz, 2019/11/11
Re: [PATCH for-5.0 v2 00/23] block: Fix check_to_replace_node(), Vladimir Sementsov-Ogievskiy, 2019/11/29