[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] iotests: Test multiple blockdev-snapshot calls
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 2/2] iotests: Test multiple blockdev-snapshot calls |
Date: |
Wed, 13 Nov 2019 10:25:02 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 12.11.2019 um 17:07 hat Peter Krempa geschrieben:
> On Fri, Nov 08, 2019 at 09:53:12 +0100, Kevin Wolf wrote:
> > Test that doing a second blockdev-snapshot doesn't make the first
> > overlay's backing file go away.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > tests/qemu-iotests/273 | 76 +++++++++
> > tests/qemu-iotests/273.out | 337 +++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/group | 1 +
> > 3 files changed, 414 insertions(+)
> > create mode 100755 tests/qemu-iotests/273
> > create mode 100644 tests/qemu-iotests/273.out
>
> Didn't apply cleanly for me.
>
> >
> > diff --git a/tests/qemu-iotests/273 b/tests/qemu-iotests/273
> > new file mode 100755
> > index 0000000000..60076de7ce
> > --- /dev/null
> > +++ b/tests/qemu-iotests/273
> > @@ -0,0 +1,76 @@
> > +#!/usr/bin/env bash
> > +#
> > +# Test large write to a qcow2 image
>
> Cut&paste?
Indeed. I'll change it like this:
# Test multiple blockdev-snapshot calls with 'backing': null
> Rest looks good
>
> Reviewed-by: Peter Krempa <address@hidden>
Thanks!
Kevin