[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/14] qapi: Move to_c_string() to common.py
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/14] qapi: Move to_c_string() to common.py |
Date: |
Thu, 14 Nov 2019 10:20:05 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Max Reitz <address@hidden> writes:
> This function will be useful for code generation once we allow default
> values, so move it to the other "C helper functions". In the process,
> rewrite it so it supports all nonprintable and non-ASCII characters.
>
> Signed-off-by: Max Reitz <address@hidden>
Please have a close look at commit 56a8caff92 "qapi: Restrict strings to
printable ASCII". Do we still need the rewrite?
If yes: the commit message title promises code motion, but the patch is
anything but. Adjust the title, please.
- Re: [Qemu-devel] [PATCH v4 02/14] qapi: Move to_c_string() to common.py,
Markus Armbruster <=