[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2 |
Date: |
Sat, 16 Nov 2019 09:41:39 +0000 |
25.10.2019 16:12, Max Reitz wrote:
> On 14.10.19 13:51, Vladimir Sementsov-Ogievskiy wrote:
>> Check that it's impossible to create more persistent bitmaps than qcow2
>> supports.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> tests/qemu-iotests/269 | 47 ++++++++++++++++++++++++++++++++++++++
>> tests/qemu-iotests/269.out | 3 +++
>> tests/qemu-iotests/group | 1 +
>> 3 files changed, 51 insertions(+)
>> create mode 100755 tests/qemu-iotests/269
>> create mode 100644 tests/qemu-iotests/269.out
>
> Is there no way to make this test any faster, e.g. by creating like
> 65534 bitmaps with dd and a binary blob? (Similarly to what I do in
> “iotests: Test qcow2's snapshot table handling”)
Seems, that's not simple.. Each bitmap should have personal name and
bitmap table..
Let's merge only patch 01 and forget about this one.
>
> This is such an edge case, but running the test took 3:46 min before
> patch 1 (which I already find much too long), and 8:13 min afterwards
> (on my machine).
>
> (To be honest, if we take this test as-is, I’m probably just never going
> to run it.)
>
> Max
>
--
Best regards,
Vladimir
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2,
Vladimir Sementsov-Ogievskiy <=