[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/33] block: Unify bdrv_child_cb_detach()
From: |
Max Reitz |
Subject: |
[PATCH v2 12/33] block: Unify bdrv_child_cb_detach() |
Date: |
Tue, 4 Feb 2020 18:08:27 +0100 |
Make bdrv_child_cb_detach() call bdrv_backing_detach() for children with
a COW role (and drop the reverse call from bdrv_backing_detach()), so it
can be used for any child (with a proper role set).
Because so far no child has a proper role set, we need a temporary new
callback for child_backing.detach that ensures bdrv_backing_detach() is
called for all COW children that do not have their role set yet.
Signed-off-by: Max Reitz <address@hidden>
---
block.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 4af81547f3..46fc08e227 100644
--- a/block.c
+++ b/block.c
@@ -921,6 +921,7 @@ static void bdrv_child_cb_drained_end(BdrvChild *child,
}
static void bdrv_backing_attach(BdrvChild *c);
+static void bdrv_backing_detach(BdrvChild *c);
static void bdrv_child_cb_attach(BdrvChild *child)
{
@@ -936,6 +937,11 @@ static void bdrv_child_cb_attach(BdrvChild *child)
static void bdrv_child_cb_detach(BdrvChild *child)
{
BlockDriverState *bs = child->opaque;
+
+ if (child->role & BDRV_CHILD_COW) {
+ bdrv_backing_detach(child);
+ }
+
bdrv_unapply_subtree_drain(child, bs);
}
@@ -1182,7 +1188,14 @@ static void bdrv_backing_detach(BdrvChild *c)
bdrv_op_unblock_all(c->bs, parent->backing_blocker);
error_free(parent->backing_blocker);
parent->backing_blocker = NULL;
+}
+/* XXX: Will be removed along with child_backing */
+static void bdrv_child_cb_detach_backing(BdrvChild *c)
+{
+ if (!(c->role & BDRV_CHILD_COW)) {
+ bdrv_backing_detach(c);
+ }
bdrv_child_cb_detach(c);
}
@@ -1230,7 +1243,7 @@ const BdrvChildClass child_backing = {
.parent_is_bds = true,
.get_parent_desc = bdrv_child_get_parent_desc,
.attach = bdrv_child_cb_attach_backing,
- .detach = bdrv_backing_detach,
+ .detach = bdrv_child_cb_detach_backing,
.inherit_options = bdrv_backing_options,
.drained_begin = bdrv_child_cb_drained_begin,
.drained_poll = bdrv_child_cb_drained_poll,
--
2.24.1
- [PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass, (continued)
- [PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass, Max Reitz, 2020/02/04
- [PATCH v2 05/33] block: Pass BdrvChildRole to bdrv_child_perm(), Max Reitz, 2020/02/04
- [PATCH v2 09/33] block: Add generic bdrv_inherited_options(), Max Reitz, 2020/02/04
- [PATCH v2 08/33] block: Rename bdrv_inherited_options(), Max Reitz, 2020/02/04
- [PATCH v2 12/33] block: Unify bdrv_child_cb_detach(),
Max Reitz <=
- [PATCH v2 14/33] block: Distinguish paths in *_format_default_perms, Max Reitz, 2020/02/04
- [PATCH v2 13/33] block: Add child_of_bds, Max Reitz, 2020/02/04
- [PATCH v2 15/33] block: Pull out bdrv_default_perms_for_backing(), Max Reitz, 2020/02/04
- [PATCH v2 10/33] block: Use bdrv_inherited_options(), Max Reitz, 2020/02/04