|
From: | Eric Blake |
Subject: | Re: [PATCH v4 01/10] hbitmap: assert that we don't create bitmap larger than INT64_MAX |
Date: | Wed, 5 Feb 2020 09:14:40 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/5/20 5:20 AM, Vladimir Sementsov-Ogievskiy wrote:
We have APIs which returns signed int64_t, to be able to return error.
s/returns/return/
Therefore we can't handle bitmaps with absolute size larger than (INT64_MAX+1). Still, keep maximum to be INT64_MAX which is a bit safer. Note, that bitmaps are used to represent disk images, which can't
s/Note,/Note/
exceed INT64_MAX anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> Reviewed-by: Max Reitz <address@hidden> --- util/hbitmap.c | 2 ++ 1 file changed, 2 insertions(+)
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |