[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] m25p80: Convert to support tracing
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH 1/3] m25p80: Convert to support tracing |
Date: |
Wed, 5 Feb 2020 18:10:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/5/20 5:35 PM, Guenter Roeck wrote:
> On Wed, Feb 05, 2020 at 11:05:04AM +0100, Cédric Le Goater wrote:
>> On 2/3/20 7:09 PM, Guenter Roeck wrote:
>>> While at it, add some trace messages to help debug problems
>>> seen when running the latest Linux kernel.
>>
>> In case you resend, It would be nice to printout a flash id in the tracing
>> else I have a patch for it on top of yours. It helped me track a squashfs
>> corruption on the Aspeed witherspoon-bmc machine which we were after since
>> 2017 or so. It seems to be a kernel bug.
>>
>
> I'll send a new version to split patch 2. Not sure I understand what you mean
> with the above. If you send me your patch I'll be happy to merge it into mine,
> otherwise we can just keep it as follow-ip patch.
Here is the idea :
https://github.com/legoater/qemu/commit/a07727e9cfc8447ea18249ff68a561f7e8883584
You can merge and maybe extend to all traces.
In the issue we had, two CS could be selected at the same time
and the SPI transfers were getting mixed. Printing out which
CS is doing what is interesting for debug.
Thanks,
C.
- [PATCH 3/3] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command, (continued)
- [PATCH 3/3] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command, Guenter Roeck, 2020/02/03
- Re: [PATCH 1/3] m25p80: Convert to support tracing, Alistair Francis, 2020/02/03
- Re: [PATCH 1/3] m25p80: Convert to support tracing, Cédric Le Goater, 2020/02/04
- Re: [PATCH 1/3] m25p80: Convert to support tracing, Philippe Mathieu-Daudé, 2020/02/04
- Re: [PATCH 1/3] m25p80: Convert to support tracing, Cédric Le Goater, 2020/02/05