[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/5] block: Generic file creation fallback
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 0/5] block: Generic file creation fallback |
Date: |
Wed, 19 Feb 2020 11:38:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 22.01.20 17:45, Max Reitz wrote:
> Hi,
>
> As version 1, this series adds a fallback path for creating files (on
> the protocol layer) if the protocol driver does not support file
> creation, but the file already exists.
>
>
> Branch: https://github.com/XanClic/qemu.git skip-proto-create-v2
> Branch: https://git.xanclic.moe/XanClic/qemu.git skip-proto-create-v2
>
>
> v2:
> - Drop blk_truncate_for_formatting(): It doesn’t make sense to introduce
> this function any more after 26536c7fc25917d1bd13781f81fe3ab039643bff
> (“block: Do not truncate file node when formatting”), because we’d
> only use it in bdrv_create_file_fallback().
> Thus, it makes more sense to create special helper functions
> specifically for bdrv_create_file_fallback().
>
> - Thus, dropped patches 2 and 3.
>
> - And changed patch 4 to include those helper functions.
>
> - Rebased, which was a bit of a pain.
Thanks for the reviews, added a note to the new test why the second case
is expected to fail (as requested by Maxim), and applied the series to
my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v2 0/5] block: Generic file creation fallback,
Max Reitz <=