[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/4] luks: implement .bdrv_measure()
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 2/4] luks: implement .bdrv_measure() |
Date: |
Wed, 19 Feb 2020 16:46:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 11.02.20 17:03, Stefan Hajnoczi wrote:
> Add qemu-img measure support in the "luks" block driver.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/crypto.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/block/crypto.c b/block/crypto.c
> index 24823835c1..453119875e 100644
> --- a/block/crypto.c
> +++ b/block/crypto.c
> @@ -484,6 +484,67 @@ static int64_t block_crypto_getlength(BlockDriverState
> *bs)
[...]
> + cryptoopts = qemu_opts_to_qdict_filtered(opts, NULL,
> + &block_crypto_create_opts_luks, true);
> + qdict_put_str(cryptoopts, "format", "luks");
> + create_opts = block_crypto_create_opts_init(cryptoopts, errp);
It looks a bit weird to me to use errp here...
> + qobject_unref(cryptoopts);
> + if (!create_opts) {
> + goto err;
> + }
> +
> + if (!qcrypto_block_calculate_payload_offset(create_opts, NULL,
> + &luks_payload_size,
> + &local_err)) {
...and local_err here. Either works, but consistent style would be a
bit nicer.
But not more correct, so:
Reviewed-by: Max Reitz <address@hidden>
> + goto err;
> + }
[...]
> +err:
> + error_propagate(errp, local_err);
> + return NULL;
> +}
signature.asc
Description: OpenPGP digital signature