[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCO
From: |
Alberto Garcia |
Subject: |
Re: [RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit |
Date: |
Thu, 20 Feb 2020 15:16:48 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 20 Feb 2020 03:12:19 PM CET, Eric Blake wrote:
>> + {
>> + .type = QCOW2_FEAT_TYPE_INCOMPATIBLE,
>> + .bit = QCOW2_INCOMPAT_EXTL2_BITNR,
>> + .name = "extended L2 entries",
>> + },
>
> I'd sort this to be grouped with the other INCOMPATIBLE bits (after
> "external data file", rather than placing a COMPATIBLE bit in the
> middle.
Ok I'll change that.
> Rebase conflict with my patches proposing the addition of an AUTOCLEAR
> bit, here and in the impacted iotests. Should be trivial to resolve,
> by whoever lands second.
Sure, although since this is a trivial change this is not that important
at this point (RFC). But of course I'll make sure that the bit is the
correct one.
Berto