[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll |
Date: |
Fri, 21 Feb 2020 16:04:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 21/02/20 15:47, Stefan Hajnoczi wrote:
>>> QLIST_SAFE_REMOVE(node, node_ready); /* remove from nested parent's
>>> list */
>>> ^---- would cause corruption if node->node_ready was stale!
>>>
>>> Would you like me to add a comment?
>> No, it's okay.
> Are you happy with this series?
Yes. Let's keep the Q*_REMOVE cleanup on the todo list. I'd keep
Q*_SAFE_REMOVE, but clear the pointer unconditionally in Q*_REMOVE so
that we can have something like Q*_IN_LIST too.
> Shall I include it in my next pull request or do you want to merge it?
No, it's yours.
Paolo
- Re: [PATCH 2/5] aio-posix: don't pass ns timeout to epoll_wait(), (continued)
- [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE(), Stefan Hajnoczi, 2020/02/14
- [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/14
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Sergio Lopez, 2020/02/19
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/19
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll,
Paolo Bonzini <=
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
[PATCH 4/5] aio-posix: make AioHandler deletion O(1), Stefan Hajnoczi, 2020/02/14
Re: [PATCH 0/5] aio-posix: towards an O(1) event loop, Stefan Hajnoczi, 2020/02/21