[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/15] migration/savevm: release gslist after dump_vmstate_json
From: |
Juan Quintela |
Subject: |
[PULL 11/15] migration/savevm: release gslist after dump_vmstate_json |
Date: |
Fri, 28 Feb 2020 10:24:16 +0100 |
From: Pan Nengyuan <address@hidden>
'list' forgot to free at the end of dump_vmstate_json_to_file(), although it's
called only once, but seems like a clean code.
Fix the leak as follow:
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x7fb946abd768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768)
#1 0x7fb945eca445 in g_malloc (/lib64/libglib-2.0.so.0+0x52445)
#2 0x7fb945ee2066 in g_slice_alloc (/lib64/libglib-2.0.so.0+0x6a066)
#3 0x7fb945ee3139 in g_slist_prepend (/lib64/libglib-2.0.so.0+0x6b139)
#4 0x5585db591581 in object_class_get_list_tramp
/mnt/sdb/qemu-new/qemu/qom/object.c:1084
#5 0x5585db590f66 in object_class_foreach_tramp
/mnt/sdb/qemu-new/qemu/qom/object.c:1028
#6 0x7fb945eb35f7 in g_hash_table_foreach (/lib64/libglib-2.0.so.0+0x3b5f7)
#7 0x5585db59110c in object_class_foreach
/mnt/sdb/qemu-new/qemu/qom/object.c:1038
#8 0x5585db5916b6 in object_class_get_list
/mnt/sdb/qemu-new/qemu/qom/object.c:1092
#9 0x5585db335ca0 in dump_vmstate_json_to_file
/mnt/sdb/qemu-new/qemu/migration/savevm.c:638
#10 0x5585daa5bcbf in main /mnt/sdb/qemu-new/qemu/vl.c:4420
#11 0x7fb941204812 in __libc_start_main ../csu/libc-start.c:308
#12 0x5585da29420d in _start
(/mnt/sdb/qemu-new/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x27f020d)
Indirect leak of 7472 byte(s) in 467 object(s) allocated from:
#0 0x7fb946abd768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768)
#1 0x7fb945eca445 in g_malloc (/lib64/libglib-2.0.so.0+0x52445)
#2 0x7fb945ee2066 in g_slice_alloc (/lib64/libglib-2.0.so.0+0x6a066)
#3 0x7fb945ee3139 in g_slist_prepend (/lib64/libglib-2.0.so.0+0x6b139)
#4 0x5585db591581 in object_class_get_list_tramp
/mnt/sdb/qemu-new/qemu/qom/object.c:1084
#5 0x5585db590f66 in object_class_foreach_tramp
/mnt/sdb/qemu-new/qemu/qom/object.c:1028
#6 0x7fb945eb35f7 in g_hash_table_foreach (/lib64/libglib-2.0.so.0+0x3b5f7)
#7 0x5585db59110c in object_class_foreach
/mnt/sdb/qemu-new/qemu/qom/object.c:1038
#8 0x5585db5916b6 in object_class_get_list
/mnt/sdb/qemu-new/qemu/qom/object.c:1092
#9 0x5585db335ca0 in dump_vmstate_json_to_file
/mnt/sdb/qemu-new/qemu/migration/savevm.c:638
#10 0x5585daa5bcbf in main /mnt/sdb/qemu-new/qemu/vl.c:4420
#11 0x7fb941204812 in __libc_start_main ../csu/libc-start.c:308
#12 0x5585da29420d in _start
(/mnt/sdb/qemu-new/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x27f020d)
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/savevm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/savevm.c b/migration/savevm.c
index 1d4220ece8..c00a6807d9 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -665,6 +665,7 @@ void dump_vmstate_json_to_file(FILE *out_file)
}
fprintf(out_file, "\n}\n");
fclose(out_file);
+ g_slist_free(list);
}
static uint32_t calculate_new_instance_id(const char *idstr)
--
2.24.1
- [PULL 01/15] multifd: Add multifd-compression parameter, (continued)
- [PULL 01/15] multifd: Add multifd-compression parameter, Juan Quintela, 2020/02/28
- [PULL 02/15] migration: Add support for modules, Juan Quintela, 2020/02/28
- [PULL 03/15] multifd: Make no compression operations into its own structure, Juan Quintela, 2020/02/28
- [PULL 04/15] multifd: Add multifd-zlib-level parameter, Juan Quintela, 2020/02/28
- [PULL 06/15] configure: Enable test and libs for zstd, Juan Quintela, 2020/02/28
- [PULL 05/15] multifd: Add zlib compression multifd support, Juan Quintela, 2020/02/28
- [PULL 07/15] multifd: Add multifd-zstd-level parameter, Juan Quintela, 2020/02/28
- [PULL 08/15] multifd: Add zstd compression multifd support, Juan Quintela, 2020/02/28
- [PULL 09/15] migration/vmstate: Remove redundant statement in vmstate_save_state_v(), Juan Quintela, 2020/02/28
- [PULL 10/15] test-vmstate: Fix memleaks in test_load_qlist, Juan Quintela, 2020/02/28
- [PULL 11/15] migration/savevm: release gslist after dump_vmstate_json,
Juan Quintela <=
- [PULL 12/15] migration/block: rename BLOCK_SIZE macro, Juan Quintela, 2020/02/28
- [PULL 13/15] migration: fix COLO broken caused by a previous commit, Juan Quintela, 2020/02/28
- [PULL 14/15] migration/colo: wrap incoming checkpoint process into new helper, Juan Quintela, 2020/02/28
- [PULL 15/15] savevm: Don't call colo_init_ram_cache twice, Juan Quintela, 2020/02/28
- Re: [PULL 00/15] Pull migration patches, Peter Maydell, 2020/02/28