[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 5/5] iotests: 287: add qcow2 compression type test
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v4 5/5] iotests: 287: add qcow2 compression type test |
Date: |
Wed, 4 Mar 2020 14:27:46 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
03.03.2020 16:34, Denis Plotnikov wrote:
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov <address@hidden>
---
tests/qemu-iotests/287 | 127 +++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/287.out | 43 +++++++++++++
tests/qemu-iotests/group | 1 +
3 files changed, 171 insertions(+)
create mode 100755 tests/qemu-iotests/287
create mode 100644 tests/qemu-iotests/287.out
diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287
new file mode 100755
index 0000000000..39cb665c85
--- /dev/null
+++ b/tests/qemu-iotests/287
[..]
+# Test: using zstd compression, write to and read from an image
+echo
+echo "=== Testing reading and writing with zstd ==="
+echo
+
+CLUSTER_SIZE=65536
+IMGOPTS='compression_type=zstd' _make_test_img 64M
As I understand, you should define env variable assignments on the same line
with _make_test_img so that they be passed to it, like
CLUSTER_SIZE=65536 IMGOPTS='compression_type=zstd' _make_test_img 64M
with this:
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
+$QEMU_IO -c "write -c -P 0xAC 65536 64k " "$TEST_IMG" | _filter_qemu_io
you may s/65536/64k/
+$QEMU_IO -c "read -P 0xAC 65536 65536 " "$TEST_IMG" | _filter_qemu_io
+$QEMU_IO -c "read -v 131070 8 " "$TEST_IMG" | _filter_qemu_io
+$QEMU_IO -c "read -v 65534 8" "$TEST_IMG" | _filter_qemu_io
+
[..]
--
Best regards,
Vladimir
- [PATCH v4 0/5] qcow2: Implement zstd cluster compression method, Denis Plotnikov, 2020/03/03
- [PATCH v4 3/5] qcow2: rework the cluster compression routine, Denis Plotnikov, 2020/03/03
- [PATCH v4 1/5] block/qcow2-threads: fix qcow2_decompress, Denis Plotnikov, 2020/03/03
- [PATCH v4 5/5] iotests: 287: add qcow2 compression type test, Denis Plotnikov, 2020/03/03
- Re: [PATCH v4 5/5] iotests: 287: add qcow2 compression type test,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v4 2/5] qcow2: introduce compression type feature, Denis Plotnikov, 2020/03/03
- [PATCH v4 4/5] qcow2: add zstd cluster compression, Denis Plotnikov, 2020/03/03