[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/9] block/block-copy: rename start to offset in interface
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 7/9] block/block-copy: rename start to offset in interfaces |
Date: |
Tue, 10 Mar 2020 16:14:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 10.03.20 15:55, Andrey Shinkevich wrote:
>
>
> On 10/03/2020 17:50, Max Reitz wrote:
>> On 06.03.20 08:38, Vladimir Sementsov-Ogievskiy wrote:
>>> offset/bytes pair is more usual naming in block layer, let's use it.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>>> Reviewed-by: Andrey Shinkevich <address@hidden>
>>> Reviewed-by: Max Reitz <address@hidden>
>>> ---
>>> include/block/block-copy.h | 4 +-
>>> block/block-copy.c | 84 +++++++++++++++++++-------------------
>>> 2 files changed, 44 insertions(+), 44 deletions(-)
>>
>> [...]
>>
>>> diff --git a/block/block-copy.c b/block/block-copy.c
>>> index 4c947e548b..2b29131653 100644
>>> --- a/block/block-copy.c
>>> +++ b/block/block-copy.c
>>> @@ -25,13 +25,13 @@
>>> #define BLOCK_COPY_MAX_MEM (128 * MiB)
>>> static BlockCopyInFlightReq
>>> *find_conflicting_inflight_req(BlockCopyState *s,
>>> - int64_t
>>> start,
>>> - int64_t
>>> bytes)
>>> + int64_t
>>> offset,
>>> + int64_t
>>> bytes)
>>
>> The alignment’s off now.
>>
>> Max
>>
>
> After applying the patch, it looks aligned in my vim editor.
I did apply it and it wasn’t aligned for me.
Now we (Red Hat) have some mailing agent for a couple of months now that
for some reason likes to change incoming mails’ encodings (in this case
from, I presume, 8bit to quoted-printable), so I have to use a script to
translate it back. But judging from what I can see in the archive:
https://lists.nongnu.org/archive/html/qemu-block/2020-03/msg00196.html
the alignment is indeed off. Otherwise, the second line (with the
@bytes parameter) would not be changed.
Max
signature.asc
Description: OpenPGP digital signature
[PATCH v3 6/9] block/block-copy: refactor interfaces to use bytes instead of end, Vladimir Sementsov-Ogievskiy, 2020/03/06
[PATCH v3 2/9] block/block-copy: fix progress calculation, Vladimir Sementsov-Ogievskiy, 2020/03/06
[PATCH v3 9/9] block/block-copy: hide structure definitions, Vladimir Sementsov-Ogievskiy, 2020/03/06
[PATCH v3 4/9] block/block-copy: use block_status, Vladimir Sementsov-Ogievskiy, 2020/03/06