[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] via-ide: fixes and improvements
From: |
John Snow |
Subject: |
Re: [PATCH 0/7] via-ide: fixes and improvements |
Date: |
Fri, 13 Mar 2020 13:57:48 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/13/20 4:24 AM, Mark Cave-Ayland wrote:
> Following on from the earlier thread "Implement "non 100% native mode"
> in via-ide", here is an updated patchset based upon the test cases
> sent to me off-list.
>
> The VIA IDE controller is similar to early versions of the PIIX
> controller in that the primary and secondary IDE channels are hardwired
> to IRQs 14 and 15 respectively. Guest OSs typically handle this by
> either switching the controller to legacy mode, or using native mode and
> using a combination of PCI device/vendor ID and/or checking various
> registers in PCI configuration space to detect this condition and apply
> a special fixed IRQ 14/15 routing.
>
> This patchset effectively updates the VIA IDE PCI device to follow the
> behaviour in the datasheet in two ways: fixing some PCI configuration
> space register defaults and behaviours, and always using legacy IRQ 14/15
> routing, and once applied allows all our known test images to boot
> correctly.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
>
>
> BALATON Zoltan (2):
> ide/via: Get rid of via_ide_init()
> pci: Honour wmask when resetting PCI_INTERRUPT_LINE
>
> Mark Cave-Ayland (5):
> via-ide: move registration of VMStateDescription to DeviceClass
> via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default
> value
> via-ide: initialise IDE controller in legacy mode
> via-ide: allow guests to write to PCI_CLASS_PROG
> via-ide: always use legacy IRQ 14/15 routing
>
> hw/ide/via.c | 21 +++++----------------
> hw/mips/mips_fulong2e.c | 5 ++++-
> hw/pci/pci.c | 5 ++++-
> include/hw/ide.h | 1 -
> 4 files changed, 13 insertions(+), 19 deletions(-)
>
Does this supersede everything else so far? (Except the two cmd646
related series, four patches total, which are already staged)
- Re: [PATCH 1/7] via-ide: move registration of VMStateDescription to DeviceClass, (continued)
- [PATCH 2/7] ide/via: Get rid of via_ide_init(), Mark Cave-Ayland, 2020/03/13
- [PATCH 3/7] pci: Honour wmask when resetting PCI_INTERRUPT_LINE, Mark Cave-Ayland, 2020/03/13
- [PATCH 4/7] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default value, Mark Cave-Ayland, 2020/03/13
- [PATCH 5/7] via-ide: initialise IDE controller in legacy mode, Mark Cave-Ayland, 2020/03/13
- [PATCH 6/7] via-ide: allow guests to write to PCI_CLASS_PROG, Mark Cave-Ayland, 2020/03/13
- [PATCH 7/7] via-ide: always use legacy IRQ 14/15 routing, Mark Cave-Ayland, 2020/03/13
- Re: [PATCH 0/7] via-ide: fixes and improvements, BALATON Zoltan, 2020/03/13
- Re: [EXTERNAL][PATCH 0/7] via-ide: fixes and improvements, Aleksandar Markovic, 2020/03/13
- Re: [PATCH 0/7] via-ide: fixes and improvements,
John Snow <=