|
From: | Eric Blake |
Subject: | Re: [RFC (fix for 5.0?)] block/io: do not do pointer arithmetic on void * |
Date: | Wed, 18 Mar 2020 09:39:01 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 3/18/20 9:26 AM, Daniel P. Berrangé wrote:
On Wed, Mar 18, 2020 at 05:22:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> --- Hi all! C standard doesn't allow pointer arithmetic on void *. Still, gcc allows it as an extension: https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer-Arith.html I can create a series of patches like this. Do we need it?I don't think so, we only care about gcc & clang.
Still, if all supported compilers support the extension, then our CODING_STYLE.rst should mention that it is safe to rely on the extension.
Also, where is documented which compilers are supported by Qemu?It is checked in configure - gcc 4.8 or clang 3.4 or xcode clang 5.1
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |