[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 11/42] nvme: add temperature threshold feature
From: |
Klaus Birkelund Jensen |
Subject: |
Re: [PATCH v6 11/42] nvme: add temperature threshold feature |
Date: |
Tue, 31 Mar 2020 07:40:42 +0200 |
On Mar 25 12:40, Maxim Levitsky wrote:
> On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote:
> > From: Klaus Jensen <address@hidden>
> >
> > It might seem wierd to implement this feature for an emulated device,
> > but it is mandatory to support and the feature is useful for testing
> > asynchronous event request support, which will be added in a later
> > patch.
> >
> > Signed-off-by: Klaus Jensen <address@hidden>
> > Acked-by: Keith Busch <address@hidden>
> > ---
> > hw/block/nvme.c | 48 ++++++++++++++++++++++++++++++++++++++++++++
> > hw/block/nvme.h | 2 ++
> > include/block/nvme.h | 8 +++++++-
> > 3 files changed, 57 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/block/nvme.h b/hw/block/nvme.h
> > index b7c465560eea..8cda5f02c622 100644
> > --- a/hw/block/nvme.h
> > +++ b/hw/block/nvme.h
> > @@ -108,6 +108,7 @@ typedef struct NvmeCtrl {
> > uint64_t irq_status;
> > uint64_t host_timestamp; /* Timestamp sent by the
> > host */
> > uint64_t timestamp_set_qemu_clock_ms; /* QEMU clock time */
> > + uint16_t temperature;
> You forgot to move this too.
>
Fixed!
>
> With 'temperature' field removed from the header:
>
> Reviewed-by: Maxim Levitsky <address@hidden>
>
> Best regards,
> Maxim Levitsky
>
[PATCH v6 16/42] nvme: make sure ncqr and nsqr is valid, Klaus Jensen, 2020/03/16
[PATCH v6 14/42] nvme: add missing mandatory features, Klaus Jensen, 2020/03/16
[PATCH v6 17/42] nvme: add log specific field to trace events, Klaus Jensen, 2020/03/16
[PATCH v6 15/42] nvme: additional tracing, Klaus Jensen, 2020/03/16