[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2] iotests: Replace deprecated ConfigParser.readfp()
From: |
Eric Blake |
Subject: |
Re: [PATCH for-5.2] iotests: Replace deprecated ConfigParser.readfp() |
Date: |
Fri, 13 Nov 2020 07:47:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/13/20 4:06 AM, Kevin Wolf wrote:
> iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning
> changes the output:
>
> nbd-fault-injector.py:230: DeprecationWarning: This method will be
> removed in future versions. Use 'parser.read_file()' instead.
>
> In fact, readfp() has already been deprecated in Python 3.2 and the
> replacement has existed since the same version, so we can now
> unconditionally switch to read_file().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/nbd-fault-injector.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
I'm happy to queue this through my NBD tree for -rc2.
>
> diff --git a/tests/qemu-iotests/nbd-fault-injector.py
> b/tests/qemu-iotests/nbd-fault-injector.py
> index 78f42c4214..6e11ef89b8 100755
> --- a/tests/qemu-iotests/nbd-fault-injector.py
> +++ b/tests/qemu-iotests/nbd-fault-injector.py
> @@ -227,7 +227,7 @@ def parse_config(config):
> def load_rules(filename):
> config = configparser.RawConfigParser()
> with open(filename, 'rt') as f:
> - config.readfp(f, filename)
> + config.read_file(f, filename)
> return parse_config(config)
>
> def open_socket(path):
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org