[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file des
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors |
Date: |
Thu, 3 Dec 2020 13:57:21 +0000 |
On Tue, Nov 24, 2020 at 08:08:26PM +0800, Coiby Xu wrote:
> Hi Stefan,
>
> On Wed, Nov 11, 2020 at 12:43:26PM +0000, Stefan Hajnoczi wrote:
> > Do not leave stdin and stdout open after fork. stdout is the
> > tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not
> > detect that qos-test has terminated and it will hang.
>
> I wonder under which situation this would happen. I couldn't re-produce
> this issue locally.
Try adding g_assert_not_reached() to one of the tests so the qos-test
process aborts. Then tap-driver.pl will hang because the pipe hasn't
been closed and "make check" never completes.
signature.asc
Description: PGP signature
- Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors,
Stefan Hajnoczi <=