[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] file-posix: detect the lock using the real file
From: |
Kevin Wolf |
Subject: |
Re: [PATCH] file-posix: detect the lock using the real file |
Date: |
Tue, 8 Dec 2020 15:38:22 +0100 |
Am 08.12.2020 um 13:59 hat Li Feng geschrieben:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> In the original code, the qemu_has_ofd_lock will test the lock on the
> "/dev/null" pseudo-file. Actually, the file.locking is per-drive property,
> which depends on the underlay filesystem.
>
> In this patch, make the 'qemu_has_ofd_lock' with a filename be more generic
> and reasonable.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
Do you know any way how I could configure either the NFS server or the
NFS client such that locking would fail? For any patch related to this,
it would be good if I could even test the scenario.
For this specific patch, I think Daniel has already provided a good
explanation of the fundamental problems it has.
Kevin
- [PATCH] file-posix: detect the lock using the real file, Li Feng, 2020/12/08
- Re: [PATCH] file-posix: detect the lock using the real file, Daniel P . Berrangé, 2020/12/08
- Re: [PATCH] file-posix: detect the lock using the real file,
Kevin Wolf <=
- Re: [PATCH] file-posix: detect the lock using the real file, Li Feng, 2020/12/08
- Re: [PATCH] file-posix: detect the lock using the real file, Daniel P . Berrangé, 2020/12/09
- Re: [PATCH] file-posix: detect the lock using the real file, Kevin Wolf, 2020/12/09
- Re: [PATCH] file-posix: detect the lock using the real file, Li Feng, 2020/12/10
- Re: [PATCH] file-posix: detect the lock using the real file, Daniel P . Berrangé, 2020/12/10
- Re: [PATCH] file-posix: detect the lock using the real file, Feng Li, 2020/12/10
- Re: [PATCH] file-posix: detect the lock using the real file, Daniel P . Berrangé, 2020/12/10
[PATCH v2] file-posix: detect the lock using the real file, Li Feng, 2020/12/08