[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] block: qcow2: remove the created file on initializati
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v3 2/2] block: qcow2: remove the created file on initialization error |
Date: |
Tue, 08 Dec 2020 17:29:07 +0200 |
User-agent: |
Evolution 3.36.5 (3.36.5-1.fc32) |
On Tue, 2020-12-08 at 16:26 +0100, Alberto Garcia wrote:
> On Tue 08 Dec 2020 03:21:59 PM CET, Maxim Levitsky wrote:
> > If the qcow initialization fails, we should remove the file if it was
> > already created, to avoid leaving stale files around.
> >
> > We already do this for luks raw images.
> >
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
>
> > ret = qcow2_co_create(create_options, errp);
> > if (ret < 0) {
> > +
> > + Error *local_delete_err = NULL;
>
> Why that empty line though?
I didn't notice. I can send a new version if this is needed.
Thanks for the review!
Best regards,
Maxim Levitsky
>
> Berto
>