[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] block: add bdrv_co_delete_file_noerr
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v4 2/4] block: add bdrv_co_delete_file_noerr |
Date: |
Wed, 09 Dec 2020 22:26:06 +0200 |
User-agent: |
Evolution 3.36.5 (3.36.5-1.fc32) |
On Wed, 2020-12-09 at 18:34 +0100, Alberto Garcia wrote:
> On Wed 09 Dec 2020 05:44:39 PM CET, Maxim Levitsky wrote:
> > +void coroutine_fn bdrv_co_delete_file_noerr(BlockDriverState *bs)
> > +{
> > + Error *local_err = NULL;
> > +
> > + if (!bs) {
> > + return;
> > + }
> > +
> > + int ret = bdrv_co_delete_file(bs, &local_err);
> ^^^
>
> According to the QEMU coding style we should not have declarations in
> the middle of a block.
Oops!
I will send next version now.
Thanks a lot for the review!
Best regards,
Maxim Levitsky
>
> The patch looks otherwise fine.
>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
>
> Berto
>