[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v15 02/13] block: add API function to insert a node
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v15 02/13] block: add API function to insert a node |
Date: |
Wed, 16 Dec 2020 09:16:52 +0300 |
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Provide API for insertion a node to backing chain.
Suggested-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
include/block/block.h | 2 ++
block.c | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 5b81e33e94..8ea794959b 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -360,6 +360,8 @@ void bdrv_append(BlockDriverState *bs_new, BlockDriverState
*bs_top,
Error **errp);
void bdrv_replace_node(BlockDriverState *from, BlockDriverState *to,
Error **errp);
+BlockDriverState *bdrv_insert_node(BlockDriverState *bs, QDict *node_options,
+ int flags, Error **errp);
int bdrv_parse_aio(const char *mode, int *flags);
int bdrv_parse_cache_mode(const char *mode, int *flags, bool *writethrough);
diff --git a/block.c b/block.c
index 8f177504d4..8ed9c5eaf9 100644
--- a/block.c
+++ b/block.c
@@ -4704,6 +4704,31 @@ static void bdrv_delete(BlockDriverState *bs)
g_free(bs);
}
+BlockDriverState *bdrv_insert_node(BlockDriverState *bs, QDict *node_options,
+ int flags, Error **errp)
+{
+ BlockDriverState *new_node_bs;
+ Error *local_err = NULL;
+
+ new_node_bs = bdrv_open(NULL, NULL, node_options, flags, errp);
+ if (new_node_bs == NULL) {
+ error_prepend(errp, "Could not create node: ");
+ return NULL;
+ }
+
+ bdrv_drained_begin(bs);
+ bdrv_replace_node(bs, new_node_bs, &local_err);
+ bdrv_drained_end(bs);
+
+ if (local_err) {
+ bdrv_unref(new_node_bs);
+ error_propagate(errp, local_err);
+ return NULL;
+ }
+
+ return new_node_bs;
+}
+
/*
* Run consistency checks on an image
*
--
2.25.4
- [PATCH v15 00/13] Apply COR-filter to the block-stream permanently, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 02/13] block: add API function to insert a node,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v15 01/13] copy-on-read: support preadv/pwritev_part functions, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 04/13] qapi: add filter-node-name to block-stream, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 05/13] qapi: copy-on-read filter: add 'bottom' option, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 03/13] copy-on-read: add filter drop function, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 06/13] iotests: add #310 to test bottom node in COR driver, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 08/13] copy-on-read: skip non-guest reads if no copy needed, Vladimir Sementsov-Ogievskiy, 2020/12/16
- [PATCH v15 09/13] stream: rework backing-file changing, Vladimir Sementsov-Ogievskiy, 2020/12/16