[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1 |
Date: |
Fri, 18 Dec 2020 11:24:29 +0100 |
Am 17.12.2020 um 16:38 hat Max Reitz geschrieben:
> Hi,
>
> See patch 2 for what’s changed in bash 5.1 that makes this series
> necessary, and what we need to do. (tl;dr: Bash presumably fixed a bug
> for array slices, and that now breaks nearly all iotests that use
> _send_qemu_cmd – but we don’t even need an array slice there.)
>
> Patch 1 fixes a bug in 102 in how it calls _send_qemu_cmd. (This
> becomes really visible with the change in patch 2.)
>
> Comparing patch 2 to v1 (“iotests: Quote $cmd in _send_qemu_cmd”), the
> reference output diffs haven’t changed, only the common.qemu hunk is
> different.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>