[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 23/30] simplebench/results_to_text: add difference line to the tab
From: |
Max Reitz |
Subject: |
[PULL 23/30] simplebench/results_to_text: add difference line to the table |
Date: |
Fri, 18 Dec 2020 16:12:42 +0100 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Performance improvements / degradations are usually discussed in
percentage. Let's make the script calculate it for us.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201021145859.11201-20-vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
[mreitz: 'seconds' instead of 'secs']
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
scripts/simplebench/results_to_text.py | 67 +++++++++++++++++++++++---
1 file changed, 60 insertions(+), 7 deletions(-)
diff --git a/scripts/simplebench/results_to_text.py
b/scripts/simplebench/results_to_text.py
index 479f7ac1d4..e46940fdf2 100644
--- a/scripts/simplebench/results_to_text.py
+++ b/scripts/simplebench/results_to_text.py
@@ -17,6 +17,10 @@
#
import math
+import tabulate
+
+# We want leading whitespace for difference row cells (see below)
+tabulate.PRESERVE_WHITESPACE = True
def format_value(x, stdev):
@@ -39,21 +43,70 @@ def result_to_text(result):
return 'FAILED'
-def results_to_text(results):
- """Return text representation of bench() returned dict."""
- from tabulate import tabulate
-
+def results_dimension(results):
dim = None
- tab = [[""] + [c['id'] for c in results['envs']]]
for case in results['cases']:
- row = [case['id']]
for env in results['envs']:
res = results['tab'][case['id']][env['id']]
if dim is None:
dim = res['dimension']
else:
assert dim == res['dimension']
+
+ assert dim in ('iops', 'seconds')
+
+ return dim
+
+
+def results_to_text(results):
+ """Return text representation of bench() returned dict."""
+ n_columns = len(results['envs'])
+ named_columns = n_columns > 2
+ dim = results_dimension(results)
+ tab = []
+
+ if named_columns:
+ # Environment columns are named A, B, ...
+ tab.append([''] + [chr(ord('A') + i) for i in range(n_columns)])
+
+ tab.append([''] + [c['id'] for c in results['envs']])
+
+ for case in results['cases']:
+ row = [case['id']]
+ case_results = results['tab'][case['id']]
+ for env in results['envs']:
+ res = case_results[env['id']]
row.append(result_to_text(res))
tab.append(row)
- return f'All results are in {dim}\n\n' + tabulate(tab)
+ # Add row of difference between columns. For each column starting from
+ # B we calculate difference with all previous columns.
+ row = ['', ''] # case name and first column
+ for i in range(1, n_columns):
+ cell = ''
+ env = results['envs'][i]
+ res = case_results[env['id']]
+
+ if 'average' not in res:
+ # Failed result
+ row.append(cell)
+ continue
+
+ for j in range(0, i):
+ env_j = results['envs'][j]
+ res_j = case_results[env_j['id']]
+ cell += ' '
+
+ if 'average' not in res_j:
+ # Failed result
+ cell += '--'
+ continue
+
+ col_j = tab[0][j + 1] if named_columns else ''
+ diff_pr = round((res['average'] - res_j['average']) /
+ res_j['average'] * 100)
+ cell += f' {col_j}{diff_pr:+}%'
+ row.append(cell)
+ tab.append(row)
+
+ return f'All results are in {dim}\n\n' + tabulate.tabulate(tab)
--
2.29.2
- [PULL 10/30] block: introduce BDRV_REQ_NO_WAIT flag, (continued)
- [PULL 10/30] block: introduce BDRV_REQ_NO_WAIT flag, Max Reitz, 2020/12/18
- [PULL 14/30] iotests: qemu_io_silent: support --image-opts, Max Reitz, 2020/12/18
- [PULL 13/30] qemu-io: add preallocate mode parameter for truncate command, Max Reitz, 2020/12/18
- [PULL 12/30] block: introduce preallocate filter, Max Reitz, 2020/12/18
- [PULL 15/30] iotests.py: execute_setup_common(): add required_fmts argument, Max Reitz, 2020/12/18
- [PULL 16/30] iotests: add 298 to test new preallocate filter driver, Max Reitz, 2020/12/18
- [PULL 19/30] scripts/simplebench: use standard deviation for +- error, Max Reitz, 2020/12/18
- [PULL 17/30] scripts/simplebench: fix grammar: s/successed/succeeded/, Max Reitz, 2020/12/18
- [PULL 18/30] scripts/simplebench: support iops, Max Reitz, 2020/12/18
- [PULL 20/30] simplebench: rename ascii() to results_to_text(), Max Reitz, 2020/12/18
- [PULL 23/30] simplebench/results_to_text: add difference line to the table,
Max Reitz <=
- [PULL 22/30] simplebench/results_to_text: improve view of the table, Max Reitz, 2020/12/18
- [PULL 21/30] simplebench: move results_to_text() into separate file, Max Reitz, 2020/12/18
- [PULL 24/30] simplebench/results_to_text: make executable, Max Reitz, 2020/12/18
- [PULL 25/30] scripts/simplebench: add bench_prealloc.py, Max Reitz, 2020/12/18
- [PULL 26/30] quorum: Implement bdrv_co_block_status(), Max Reitz, 2020/12/18
- [PULL 27/30] quorum: Implement bdrv_co_pwrite_zeroes(), Max Reitz, 2020/12/18
- [PULL 28/30] block/nvme: Implement fake truncate() coroutine, Max Reitz, 2020/12/18
- [PULL 29/30] iotests/102: Pass $QEMU_HANDLE to _send_qemu_cmd, Max Reitz, 2020/12/18
- [PULL 30/30] iotests: Fix _send_qemu_cmd with bash 5.1, Max Reitz, 2020/12/18