[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v13 7/7] tests/test-char.c: Wait for the chardev to connect in ch
From: |
Lukas Straub |
Subject: |
[PATCH v13 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test |
Date: |
Mon, 28 Dec 2020 15:58:57 +0100 |
A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
yank_register_instance will abort, because the yank instance is
already/still registered.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/test-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index 953e0d1c1f..41a76410d8 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -937,6 +937,7 @@ static void char_socket_client_dupid_test(gconstpointer
opaque)
g_assert_nonnull(opts);
chr1 = qemu_chr_new_from_opts(opts, NULL, &error_abort);
g_assert_nonnull(chr1);
+ qemu_chr_wait_connected(chr1, &error_abort);
chr2 = qemu_chr_new_from_opts(opts, NULL, &local_err);
g_assert_null(chr2);
--
2.29.2
pgp8jlrExKfu4.pgp
Description: OpenPGP digital signature
- [PATCH v13 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu, Lukas Straub, 2020/12/28
- [PATCH v13 1/7] Introduce yank feature, Lukas Straub, 2020/12/28
- [PATCH v13 2/7] block/nbd.c: Add yank feature, Lukas Straub, 2020/12/28
- [PATCH v13 3/7] chardev/char-socket.c: Add yank feature, Lukas Straub, 2020/12/28
- [PATCH v13 4/7] migration: Add yank feature, Lukas Straub, 2020/12/28
- [PATCH v13 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe, Lukas Straub, 2020/12/28
- [PATCH v13 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown, Lukas Straub, 2020/12/28
- [PATCH v13 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test,
Lukas Straub <=