Re: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline

[no-reply]

Patchew URL: 
20210118063808.12471-1-jiaxun.yang@flygoat.com/">https://patchew.org/QEMU/20210118063808.12471-1-jiaxun.yang@flygoat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210118063808.12471-1-jiaxun.yang@flygoat.com
Subject: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210118063808.12471-1-jiaxun.yang@flygoat.com -> 
patchew/20210118063808.12471-1-jiaxun.yang@flygoat.com
 * [new tag]         patchew/20210118065627.79903-1-ganqixin@huawei.com -> 
patchew/20210118065627.79903-1-ganqixin@huawei.com
Switched to a new branch 'test'
eeef33a gitlab-ci: Add alpine to pipeline
85ea588 tests/docker: Add dockerfile for Alpine Linux
9f5e3ca accel/kvm: avoid using predefined PAGE_SIZE
0292db5 tests: Rename PAGE_SIZE definitions
fdcacb9 elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE
9ff36c5 hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE
b096605 osdep.h: Remove <sys/signal.h> include
9e5e67d libvhost-user: Include poll.h instead of sys/poll.h
c20bc72 configure: Add sys/timex.h to probe clock_adjtime

=== OUTPUT BEGIN ===
1/9 Checking commit c20bc7253f10 (configure: Add sys/timex.h to probe 
clock_adjtime)
2/9 Checking commit 9e5e67d01f91 (libvhost-user: Include poll.h instead of 
sys/poll.h)
3/9 Checking commit b0966056d77e (osdep.h: Remove <sys/signal.h> include)
4/9 Checking commit 9ff36c58081b (hw/block/nand: Rename PAGE_SIZE to 
NAND_PAGE_SIZE)
ERROR: code indent should never use tabs
#27: FILE: hw/block/nand.c:118:
+# define PAGE_START(page)^I(PAGE(page) * (NAND_PAGE_SIZE + OOB_SIZE))$

ERROR: code indent should never use tabs
#47: FILE: hw/block/nand.c:135:
+# define NAND_PAGE_SIZE^I^I2048$

WARNING: line over 80 characters
#66: FILE: hw/block/nand.c:675:
+        mem_and(iobuf + (soff | off), s->io, MIN(s->iolen, NAND_PAGE_SIZE - 
off));

WARNING: line over 80 characters
#71: FILE: hw/block/nand.c:678:
+            mem_and(s->storage + (page << OOB_SHIFT), s->io + NAND_PAGE_SIZE - 
off,

total: 2 errors, 2 warnings, 120 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit fdcacb94e921 (elf2dmp: Rename PAGE_SIZE to 
ELF2DMP_PAGE_SIZE)
WARNING: line over 80 characters
#70: FILE: contrib/elf2dmp/main.c:284:
+        h.PhysicalMemoryBlock.NumberOfPages += ps->block[i].size / 
ELF2DMP_PAGE_SIZE;

WARNING: line over 80 characters
#80: FILE: contrib/elf2dmp/main.c:291:
+    h.RequiredDumpSpace += h.PhysicalMemoryBlock.NumberOfPages << 
ELF2DMP_PAGE_BITS;

total: 0 errors, 2 warnings, 70 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 0292db5a571a (tests: Rename PAGE_SIZE definitions)
7/9 Checking commit 9f5e3ca96943 (accel/kvm: avoid using predefined PAGE_SIZE)
8/9 Checking commit 85ea5884f78d (tests/docker: Add dockerfile for Alpine Linux)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit eeef33a77edf (gitlab-ci: Add alpine to pipeline)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210118063808.12471-1-jiaxun.yang@flygoat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210118063808.12471-1-jiaxun.yang@flygoat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com