Re: [RFC PATCH V2 10/11] hw/block/nvme: add NMIC enum value for Identify Namespace

[Klaus Jensen]

On Jan 17 23:53, Minwoo Im wrote:
> Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC)
> field to support shared namespace from controller(s).
> 
> This field is in Identify Namespace data structure in [30].
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>  include/block/nvme.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/block/nvme.h b/include/block/nvme.h
> index e83ec1e124c6..dd7b5ba9ef4c 100644
> --- a/include/block/nvme.h
> +++ b/include/block/nvme.h
> @@ -1110,6 +1110,10 @@ enum NvmeNsIdentifierType {
>      NVME_NIDT_CSI               = 0x04,
>  };
>  
> +enum NvmeNsNmic {
> +    NVME_NMIC_NS_SHARED         = 1 << 0,
> +};
> +

Let's keep convention (or should be convention...) of using NvmeIdNs
prefix for identify data structure fields on the enum.

signature.asc
Description: PGP signature