[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 0/2] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-ty
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [RFC PATCH 0/2] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error |
|
Date: |
Tue, 19 Jan 2021 17:49:48 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/19/21 5:41 PM, Gerd Hoffmann wrote:
> On Mon, Jan 18, 2021 at 06:03:06PM +0100, Philippe Mathieu-Daudé wrote:
>> Another attempt to fix the following Clang 11 warning:
>>
>> usb/dev-uas.c:157:31: error: field 'status' with variable sized type
>> 'uas_i=
>> u' not at the end of a struct or class is a GNU extension
>> [-Werror,-Wgnu-vari=
>> able-sized-type-not-at-end]
>> uas_iu status;
>> ^
>> If a guest send a packet with additional data, respond
>> with "Illegal Request - parameter not supported".
>
> Why rfc? looks good to me as-is ;)
Sorry I forgot to explain. RFC because I don't know enough SCSI
to be sure than the device returning sense_code_INVALID_PARAM_VALUE
on the bus is appropriate. This is the best fit I could find.
>
> thanks,
> Gerd
>