Re: [PATCH v7 00/11] Rework iotests/check

[Kevin Wolf]

Am 22.01.2021 um 17:08 hat Eric Blake geschrieben:
> On 1/22/21 5:27 AM, Kevin Wolf wrote:
> > Am 20.01.2021 um 21:52 hat Eric Blake geschrieben:
> >> On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote:
> >>> Hi all!
> >>>
> >>> These series has 3 goals:
> >>>
> >>>  - get rid of group file (to forget about rebase and in-list conflicts)
> >>>  - introduce human-readable names for tests
> >>>  - rewrite check into python
> >>>
> >>> v7:
> >>>   - fix wording and grammar
> >>>   - satisfy python linters
> >>>   - move argv interfaces all into one in new check script
> >>>   - support '-n' == '--dry-run' option
> >>>   - update check-block to run check with correct PYTHON
> >>
> >> I'd really like a second reviewer on 7-11, but I'm queueing 1-6 on my
> >> NBD tree now.
> > 
> > Oh, you already sent a pull request? Having 6 in without the rest is not
> > a good state. We now have the group info duplicated and one of them is
> > ignored, but will become the meaningful copy later. We need to be
> > careful to not let them diverge now.
> > 
> > I hope the rest is fine so we can switch over quickly, otherwise I'd
> > prefer to revert 6 and redo it from the then current state when we merge
> > the whole series.
> 
> Yeah, I probably jumped the gun there.  If we don't have v8 in good
> working shape soon, I'm happy to send a temporary revert pull request
> for patch 6 - let's shoot for late Monday as the cut-off point where I
> will act if the revert is needed.

I think I'm going to send a pull request anyway, so I could include it
there if necessary.

Kevin